Horde3D

Next-Generation Graphics Engine
It is currently 28.04.2024, 00:02

All times are UTC + 1 hour




Post new topic Reply to topic  [ 2 posts ] 
Author Message
PostPosted: 30.05.2010, 15:50 
Offline

Joined: 26.08.2008, 18:48
Posts: 120
In ShaderResource::parseFXSection the comment replacer code can cause buffer overrun if
there is a non-closed /* comment at the end of the buffer.
Ending zero should be checked in the inner loop.

I couldn't create a problematic test case with // comment but a check for 0 in that inner loop wouldn't hurt either.


Top
 Profile  
Reply with quote  
PostPosted: 03.06.2010, 19:05 
Offline
Tool Developer

Joined: 13.11.2007, 11:07
Posts: 1150
Location: Germany
Thanks for pointing that out, should be fixed now in the trunk.


Top
 Profile  
Reply with quote  
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 2 posts ] 

All times are UTC + 1 hour


Who is online

Users browsing this forum: No registered users and 9 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
cron
Powered by phpBB® Forum Software © phpBB Group