Horde3D

Hi,

I've made a patch to add framebuffer multisample to the engine. It's up here:

http://www.jareiko.net/code/framebuffer_multisample-reiko-20080311.patch

Any comments?

Remaining issues:
* I haven't tested it on multiple color attachments
* It would also be useful to add a hint to the pipeline target whether the depth buffer needs to be resolved to a texture. At the moment, a multisample depth buffer will always be downsampled to a texture, even if that texture is not needed.

Very nice, thanks a lot!

Since my current project is high-quality facial rendering I could really profit from anti-aliasing. I will take a look at the code in the next time...

I have just integrated your patch. The code was almost perfectly clean and consistent with the engine style. I just did a quick test (which was working) but I will try it out more precisely another day.

Excellent work, thank you very much again!

No problem

By the way, I just noticed that you have .suo files in svn. These are Visual Studio's user option files, and probably shouldn't be in svn, since they will interfere with other Visual Studio users' .suo files when they sync the repository. They contain interface settings like which tree folders are expanded in the project, preferences, etc.

Yeah I know, Volker was already complaining about that too. The suo file also stores the files opened in the editor. When I'm working on different machines, I just find it useful to see directly which files I have modified most recently. That's why the suo is still in the repository.

Wouldn't the SVN log fulfil the same function?

Yes it would. Having the suo in the respository is nice when you are the only developer (working on different machines) but for more people it does not make much sense.

I just wanted the remove the suo file from the svn and now I remember why I had added it originally. It stores the configuration (debug/release) and the start project and I wanted that people just have to hit F5 after loading the solution from the SDK for the first time.

Did you get to test multisampled FBO with multiple color attachment?.

I did some initial testing and only get antialiasing in the first color attachment (colBuf0).

Do you know if there is an actual limitation with this?

_________________
r3D^rgba

Honestly we never tested MSAA with multiple render targets, so it is well possible that it is broken or not implemented properly We need to check that.

For multiple render targets it makes sense to add optional support for the new ARB_texture_multisample extension as well. This would make it possible to do MSAA with deferred shading (on GL3/D3D10 hardware).